Scanner reskin: amber → blue boundary channel + build never-built S6/S7 states
Semantic COLOR fix, not cosmetic. The S6/S7 build predated the current Scanner
States spec: it used AMBER (the quarantine / model-suppressed channel) for the
"no market / line not priced" case, telling users "model suppressed" when the
truth is "the board never priced this." Corrected to the HANDOFF Session-3
blue-boundary law: BLUE (--priced-out #8FB2DE) = no-market boundary; amber stays
QUARANTINE; red stays REFUSAL.
Phase 1 (reskin): NoMarketState → dashed BLUE void box + blue header/copy; the
S7 rows → spec format (o 27.5 · BK −114 · ◆ −105 · OPEN READ ▸) at 44px,
390-legible. Input-area surfacer pills reskinned to the blue channel too.
Phase 2 (never-built states, only those Phase 0 confirmed against live data):
- GREEN CTA with LIVE player count ("PLAYER · N PRICED PROPS ▸"), degrading
honestly to the board path ("N PROPS LIVE · TONIGHT'S BOARD ▸") at 0 — count
from the SAME fresh index as the rows (pricedCountForPlayer), can't disagree.
- CASE A none-priced DEFAULT: "WE PRICE THESE FOR [player]" — the player's other
priced stats (pricedStatsForPlayer, filter by nameKey).
- Typed-line-mismatch blue fact line ("o X ISN'T PRICED · NEAREST ↓").
FLAGGED / not built (no shells): Case C off-slate quiet-stop needs schedule/
roster membership the pricedLines index doesn't carry (out of the presentation
fence). Spec CONTRADICTION: Case B says "fair previews amber," but the law
reserves amber for quarantine — fair renders NEUTRAL ◆ (blue-dim), not amber, to
avoid blurring the channel.
Free-tier gate VERIFIED before rendering FAIR: fair_odds is the de-vigged MARKET
price (valueState: "never hide the honest fair number"), NOT the gated
model_odds — no paid leak. Carried through indexPricedLines (additive; keying/
refresh/onPick/stale-tap all unchanged — the proven S7 data path is untouched).
Scan A byte-identical; PRICED_NUDGE_ENABLED still the kill switch; reversible.
Build exit 0; priced + parity suites green (67).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCNgGSt5qvcLxaeQqa7Zpj
This commit is contained in:
@@ -3,7 +3,10 @@
|
||||
NON-FABRICATING: only real snapshot lines with a real book price surface.
|
||||
============================================================ */
|
||||
|
||||
const { indexPricedLines, pricedLinesFor } = require('../../web/src/lib/pricedLines');
|
||||
const {
|
||||
indexPricedLines, pricedLinesFor, pricedStatsForPlayer, pricedCountForPlayer,
|
||||
totalPricedCount, nearestPricedLine,
|
||||
} = require('../../web/src/lib/pricedLines');
|
||||
|
||||
const GRADES = [
|
||||
{ player_name: 'Gabriel Arias', stat_type: 'hits', line: 0.5, direction: 'over', book_odds: -165, fair_odds: -140 },
|
||||
@@ -17,7 +20,16 @@ describe('indexPricedLines — only real, priced rows', () => {
|
||||
it('indexes a priced row by player+stat', () => {
|
||||
const idx = indexPricedLines(GRADES);
|
||||
const rows = pricedLinesFor(idx, 'Gabriel Arias', 'hits');
|
||||
expect(rows).toEqual([{ line: 0.5, direction: 'over', book_odds: -165 }]);
|
||||
// fair_odds is the de-vigged MARKET price, carried through for the S7 ◆ FAIR
|
||||
// cell (free-tier visible — NOT the gated model_odds).
|
||||
expect(rows).toEqual([{ line: 0.5, direction: 'over', book_odds: -165, fair_odds: -140 }]);
|
||||
});
|
||||
|
||||
it('carries fair_odds strictly (null when absent — never Number(null)===0)', () => {
|
||||
const idx = indexPricedLines([
|
||||
{ player_name: 'Y', stat_type: 'hits', line: 0.5, direction: 'over', book_odds: -110 }, // no fair
|
||||
]);
|
||||
expect(pricedLinesFor(idx, 'Y', 'hits')[0].fair_odds).toBeNull();
|
||||
});
|
||||
|
||||
it('EXCLUDES a graded row with no book price — not a surfaceable line', () => {
|
||||
@@ -65,6 +77,55 @@ describe('indexPricedLines — only real, priced rows', () => {
|
||||
});
|
||||
});
|
||||
|
||||
// ── S7 reskin — count + Case-A helpers, all from the SAME fresh index ────────
|
||||
describe('pricedStatsForPlayer / count / board — one source, honest degrade', () => {
|
||||
const MULTI = [
|
||||
{ player_name: 'Justin Herbert', stat_type: 'pass_yds', line: 275.5, direction: 'over', book_odds: -115, fair_odds: -108 },
|
||||
{ player_name: 'Justin Herbert', stat_type: 'pass_td', line: 1.5, direction: 'over', book_odds: 120, fair_odds: 135 },
|
||||
{ player_name: 'Justin Herbert', stat_type: 'interceptions', line: 0.5, direction: 'over', book_odds: 150, fair_odds: 170 },
|
||||
{ player_name: 'Other Guy', stat_type: 'hits', line: 0.5, direction: 'over', book_odds: -110, fair_odds: -100 },
|
||||
];
|
||||
|
||||
it('pricedStatsForPlayer returns the player\'s priced stats across the board', () => {
|
||||
const idx = indexPricedLines(MULTI);
|
||||
const stats = pricedStatsForPlayer(idx, 'Justin Herbert').map((s) => s.stat).sort();
|
||||
expect(stats).toEqual(['interceptions', 'pass_td', 'pass_yds']);
|
||||
});
|
||||
|
||||
it('excludeStat drops the already-selected stat (Case A "these OTHERS")', () => {
|
||||
const idx = indexPricedLines(MULTI);
|
||||
const stats = pricedStatsForPlayer(idx, 'Justin Herbert', 'pass_yds').map((s) => s.stat).sort();
|
||||
expect(stats).toEqual(['interceptions', 'pass_td']);
|
||||
});
|
||||
|
||||
it('count comes from the SAME index as the rows (can\'t disagree)', () => {
|
||||
const idx = indexPricedLines(MULTI);
|
||||
expect(pricedCountForPlayer(idx, 'Justin Herbert')).toBe(3);
|
||||
});
|
||||
|
||||
it('count is 0 for an off-slate player → caller degrades, never "0 PROPS"', () => {
|
||||
const idx = indexPricedLines(MULTI);
|
||||
expect(pricedCountForPlayer(idx, 'Nobody Here')).toBe(0);
|
||||
});
|
||||
|
||||
it('totalPricedCount is the board-wide prop count (real exhaust or 0)', () => {
|
||||
expect(totalPricedCount(indexPricedLines(MULTI))).toBe(4);
|
||||
expect(totalPricedCount(indexPricedLines([]))).toBe(0);
|
||||
expect(totalPricedCount(null)).toBe(0);
|
||||
});
|
||||
|
||||
it('nearestPricedLine picks the closest priced line to a typed line', () => {
|
||||
const idx = indexPricedLines([
|
||||
{ player_name: 'Z', stat_type: 'points', line: 27.5, direction: 'over', book_odds: -114, fair_odds: -105 },
|
||||
{ player_name: 'Z', stat_type: 'points', line: 24.5, direction: 'over', book_odds: -120, fair_odds: -110 },
|
||||
]);
|
||||
expect(nearestPricedLine(idx, 'Z', 'points', 30.5).line).toBe(27.5);
|
||||
expect(nearestPricedLine(idx, 'Z', 'points', 24).line).toBe(24.5);
|
||||
expect(nearestPricedLine(idx, 'Z', 'points', null).line).toBe(24.5); // sorted first
|
||||
expect(nearestPricedLine(idx, 'Nobody', 'points', 30)).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe('the empty state + surfacer are independently reversible', () => {
|
||||
const fs = require('fs');
|
||||
it('the working card/join/triplet are untouched (Scan A byte-identical)', () => {
|
||||
|
||||
Reference in New Issue
Block a user