feat: Feature 1.2 (NBA stats FastAPI service) + Feature 1.4 (database schema)

Feature 1.2: Python FastAPI microservice wrapping nba_api - GET /stats/season-avg, /stats/last-n, /stats/splits, /players/search - Redis caching (24hr/1hr/6hr/7day), 0.6s rate limiting, PRA derived stat - 27 Python tests passing Feature 1.4: Complete Supabase database schema - 6 tables: users, picks, scan_sessions, bets, outcomes, performance - RLS enabled on all tables with auth.uid() policies - 3 triggers: auto-create user, updated_at, scan count reset - 37 schema validation tests passing - Migration SQL ready, pending manual apply (WSL2 DNS blocker) Total: 92 tests (65 Node.js + 27 Python), all passing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-21 10:58:58 -04:00
parent 00409fd6cd
commit 3da1b4242c
27 changed files with 2360 additions and 16 deletions
@@ -0,0 +1,170 @@
+import sys
+import os
+import pytest
+from unittest.mock import patch, MagicMock
+from httpx import AsyncClient, ASGITransport
+import pandas as pd
+
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), ".."))
+
+from app.main import app
+
+MOCK_CAREER_DF = pd.DataFrame([{
+    "SEASON_ID": "2025-26",
+    "TEAM_ABBREVIATION": "DEN",
+    "PTS": 26.3, "REB": 12.4, "AST": 9.1, "FG3M": 1.1,
+    "BLK": 0.7, "STL": 1.4, "TOV": 3.2, "MIN": 34.2, "GP": 65,
+}])
+
+MOCK_GAMELOG_DF = pd.DataFrame([
+    {
+        "GAME_DATE": "MAR 21, 2026", "MATCHUP": "DEN vs. LAL",
+        "TEAM_ABBREVIATION": "DEN",
+        "PTS": 30, "REB": 15, "AST": 10, "FG3M": 2, "BLK": 1, "STL": 2, "TOV": 3, "MIN": 36,
+    },
+    {
+        "GAME_DATE": "MAR 20, 2026", "MATCHUP": "DEN @ PHX",
+        "TEAM_ABBREVIATION": "DEN",
+        "PTS": 22, "REB": 10, "AST": 8, "FG3M": 0, "BLK": 0, "STL": 1, "TOV": 4, "MIN": 32,
+    },
+])
+
+MOCK_PLAYERS = [{"id": 203999, "full_name": "Nikola Jokic", "is_active": True}]
+
+
+def mock_career(*args, **kwargs):
+    m = MagicMock()
+    m.get_data_frames.return_value = [MOCK_CAREER_DF]
+    return m
+
+
+def mock_gamelog(*args, **kwargs):
+    m = MagicMock()
+    m.get_data_frames.return_value = [MOCK_GAMELOG_DF]
+    return m
+
+
+@pytest.fixture
+def mock_nba_api():
+    with patch("app.services.stats.playercareerstats.PlayerCareerStats", side_effect=mock_career), \
+         patch("app.services.stats.playergamelog.PlayerGameLog", side_effect=mock_gamelog), \
+         patch("app.utils.player_map.players.get_players", return_value=MOCK_PLAYERS), \
+         patch("app.services.stats.cache_get", return_value=None), \
+         patch("app.services.stats.cache_set"), \
+         patch("app.utils.player_map.cache_get", return_value=None), \
+         patch("app.utils.player_map.cache_set"), \
+         patch("app.services.stats.time.sleep"):
+        yield
+
+
+@pytest.mark.asyncio
+async def test_health():
+    with patch("app.main.cache_health", return_value=True):
+        transport = ASGITransport(app=app)
+        async with AsyncClient(transport=transport, base_url="http://test") as client:
+            resp = await client.get("/health")
+            assert resp.status_code == 200
+            assert resp.json()["status"] == "ok"
+
+
+@pytest.mark.asyncio
+async def test_player_search(mock_nba_api):
+    transport = ASGITransport(app=app)
+    async with AsyncClient(transport=transport, base_url="http://test") as client:
+        resp = await client.get("/players/search?name=Jokic")
+        assert resp.status_code == 200
+        assert len(resp.json()["results"]) > 0
+        assert resp.json()["results"][0]["full_name"] == "Nikola Jokic"
+
+
+@pytest.mark.asyncio
+async def test_player_search_not_found():
+    with patch("app.utils.player_map.players.get_players", return_value=[]), \
+         patch("app.utils.player_map.cache_get", return_value=None), \
+         patch("app.utils.player_map.cache_set"):
+        transport = ASGITransport(app=app)
+        async with AsyncClient(transport=transport, base_url="http://test") as client:
+            resp = await client.get("/players/search?name=Zzzzzzz")
+            assert resp.status_code == 404
+
+
+@pytest.mark.asyncio
+async def test_season_avg(mock_nba_api):
+    transport = ASGITransport(app=app)
+    async with AsyncClient(transport=transport, base_url="http://test") as client:
+        resp = await client.get("/stats/season-avg?player=Nikola Jokic&season=2025-26")
+        assert resp.status_code == 200
+        data = resp.json()
+        assert data["player"] == "Nikola Jokic"
+        assert data["team"] == "DEN"
+        assert "points" in data["stats"]
+        assert "pra" in data["stats"]
+
+
+@pytest.mark.asyncio
+async def test_season_avg_invalid_stat_type(mock_nba_api):
+    transport = ASGITransport(app=app)
+    async with AsyncClient(transport=transport, base_url="http://test") as client:
+        resp = await client.get("/stats/season-avg?player=Jokic&stat_type=invalid")
+        assert resp.status_code == 400
+
+
+@pytest.mark.asyncio
+async def test_last_n(mock_nba_api):
+    transport = ASGITransport(app=app)
+    async with AsyncClient(transport=transport, base_url="http://test") as client:
+        resp = await client.get("/stats/last-n?player=Nikola Jokic&n=2")
+        assert resp.status_code == 200
+        data = resp.json()
+        assert data["last_n"] == 2
+        assert "points" in data["stats"]
+
+
+@pytest.mark.asyncio
+async def test_last_n_clamps_max(mock_nba_api):
+    transport = ASGITransport(app=app)
+    async with AsyncClient(transport=transport, base_url="http://test") as client:
+        resp = await client.get("/stats/last-n?player=Nikola Jokic&n=50")
+        # FastAPI validates n <= 30, returns 422
+        assert resp.status_code == 422
+
+
+@pytest.mark.asyncio
+async def test_splits_home_away(mock_nba_api):
+    transport = ASGITransport(app=app)
+    async with AsyncClient(transport=transport, base_url="http://test") as client:
+        resp = await client.get("/stats/splits?player=Nikola Jokic&stat_type=points&split_type=home_away")
+        assert resp.status_code == 200
+        data = resp.json()
+        assert "home" in data["splits"]
+        assert "away" in data["splits"]
+
+
+@pytest.mark.asyncio
+async def test_splits_vs_team_requires_opponent(mock_nba_api):
+    transport = ASGITransport(app=app)
+    async with AsyncClient(transport=transport, base_url="http://test") as client:
+        resp = await client.get("/stats/splits?player=Jokic&stat_type=points&split_type=vs_team")
+        assert resp.status_code == 400
+        assert "opponent" in resp.json()["detail"]
+
+
+@pytest.mark.asyncio
+async def test_splits_invalid_split_type(mock_nba_api):
+    transport = ASGITransport(app=app)
+    async with AsyncClient(transport=transport, base_url="http://test") as client:
+        resp = await client.get("/stats/splits?player=Jokic&stat_type=points&split_type=invalid")
+        assert resp.status_code == 400
+
+
+@pytest.mark.asyncio
+async def test_season_avg_player_not_found():
+    with patch("app.utils.player_map.players.get_players", return_value=[]), \
+         patch("app.utils.player_map.cache_get", return_value=None), \
+         patch("app.utils.player_map.cache_set"), \
+         patch("app.services.stats.cache_get", return_value=None), \
+         patch("app.services.stats.time.sleep"):
+        transport = ASGITransport(app=app)
+        async with AsyncClient(transport=transport, base_url="http://test") as client:
+            resp = await client.get("/stats/season-avg?player=Nobody")
+            assert resp.status_code == 404