Session 54: Audit cleanup — name edges + polish (2255 tests)

P1 name edge cases (BOTH playerName.js copies, kept identical):
- normalizeName strips hyphens (display+key): "Jung-hoo Lee" === "Jung Hoo Lee".
- nameKey strips single-letter MIDDLE tokens: "Josh H Smith" === "Josh Smith"
  (keeps first+last; real middle names + collapsed initials untouched).
- richie -> richard added to NICKNAMES.

P2 polish:
- Team Hub names normalized at the source (teamService.getTeamHub) so
  "J.C. Escarra" renders as "JC Escarra" like the dashboard.
- snapshotService dedup keeps the highest-confidence GRADE but the richest
  DISPLAY (accented "José" over "Jose") so prop rows match the pitcher line.
- correlationWarning names the game: "2 legs from the same game (NYY @ BOS)".

Backend 2246 -> 2255 tests (+9), 194 suites. Web build clean (exit 0).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Kev
2026-06-19 15:45:07 -04:00
parent b012da13f8
commit 8629021774
11 changed files with 137 additions and 12 deletions
+1 -1
View File
File diff suppressed because one or more lines are too long
+8 -1
View File
@@ -18,6 +18,7 @@ const NICKNAMES = {
jim: 'james', jimmy: 'james', ray: 'raymond', fred: 'frederick',
kenny: 'kenneth', sam: 'samuel', pat: 'patrick', greg: 'gregory',
steve: 'steven', tim: 'timothy', frank: 'francis', mickey: 'michael',
richie: 'richard',
};
// Collapse adjacent single-letter words: "J C Escarra" → "JC Escarra".
@@ -29,6 +30,7 @@ function normalizeName(raw) {
const display = collapseInitials(String(raw == null ? '' : raw)
.replace(/\s*\([^)]*\)\s*/g, ' ')
.replace(/\./g, '')
.replace(/-/g, ' ')
.replace(/\s+/g, ' ')
.trim());
const folded = display.normalize('NFD').replace(/[̀-ͯ]/g, '').toLowerCase();
@@ -38,8 +40,13 @@ function normalizeName(raw) {
function nameKey(raw) {
const { key } = normalizeName(raw);
const parts = key.split(/\s+/).filter(Boolean);
let parts = key.split(/\s+/).filter(Boolean);
if (parts.length >= 2 && NICKNAMES[parts[0]]) parts[0] = NICKNAMES[parts[0]];
// Strip single-letter MIDDLE tokens ("josh h smith" → "josh smith"); keep the
// first (may be a collapsed initial like "jc") and last token.
if (parts.length >= 3) {
parts = parts.filter((p, i, arr) => i === 0 || i === arr.length - 1 || p.length > 1);
}
return parts.join(' ');
}