Statcast: role belongs in the key (two-way players)

Found by inducing the real job on the server, not by review: the first chunk
wrote, the second failed with 'ON CONFLICT DO UPDATE command cannot affect row
a second time'. A player can legitimately appear in BOTH the batter and the
pitcher feeds — two-way players, position players who pitch, pitchers who bat —
so (sport, season, source_id) collapsed two real profiles into one key and a
single batch hit the same row twice.

Ohtani has a real batter profile and a real pitcher profile. Merging them would
invent one player out of two genuinely different sets of measurements, so role
goes in the primary key rather than one profile winning. Migration 031 applied;
conflict target updated; a two-way case is now a test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCNgGSt5qvcLxaeQqa7Zpj

tests/unit/statcastAggregate.test.js

@@ -131,7 +131,7 @@ describe('refreshSeason — the job', () => {
     let opts = null;
     const sb = { from: () => ({ upsert: async (_b, o) => { opts = o; return { error: null }; } }) };
     await svc.refreshSeason({ supabase: sb, fetchSeason: async () => feeds({ batter: [BELL] }) });
-    expect(opts.onConflict).toBe('sport,season,source_id');
+    expect(opts.onConflict).toBe('sport,season,source_id,role');
   });
 
   it('REFUSES to write when every feed is empty — a bad night cannot blank a good table', async () => {
@@ -148,6 +148,18 @@ describe('refreshSeason — the job', () => {
     expect(sb.calls[0][0]._sufficient).toBeUndefined();
   });
 
+  it('keys two-way players by ROLE — one player, two real profiles', async () => {
+    // Ohtani appears in both the batter and the pitcher feeds. Without role in
+    // the key, one upsert batch hits the same row twice and Postgres refuses
+    // the whole chunk — found by inducing the real job, not by review.
+    const OHTANI_B = { 'last_name, first_name': 'Ohtani, Shohei', player_id: '660271', pa: '400' };
+    const OHTANI_P = { 'last_name, first_name': 'Ohtani, Shohei', player_id: '660271', p_formatted_ip: '40' };
+    const rows = svc.buildRows(2026, feeds({ batter: [OHTANI_B], pitcher: [OHTANI_P] }), {});
+    expect(rows).toHaveLength(2);
+    expect(new Set(rows.map((r) => r.source_id)).size).toBe(1);
+    expect(new Set(rows.map((r) => r.role))).toEqual(new Set(['batter', 'pitcher']));
+  });
+
   it('reports the join rate — the honest-absent rate for the mechanism tier', async () => {
     const out = await svc.refreshSeason({
       supabase: okClient(),