Session 57: Phase 0 — Kill the Lies (2309 tests)
Work-order Phase 0 (Jul 10 live audit): every fabricated UI element deleted
or rewired to real data. Deletion sprint — no new product features.
0.1 Fake NBA game: root cause was scheduleService fetching the ESPN
scoreboard with no ?dates= param or date filter — off-season ESPN
returns the NEAREST slate (Jun 13 NYK@SA Finals rendered as tonight).
Now pinned to the requested ET date + defensive filter; undated events
dropped. Honest month-aware per-sport empty states (lib/emptyState.js).
0.2 Fake header counters: liveTick stripped to a bare 1s pulse (the
auto-incrementing "247 graded", sin-driven brain-%, aPlus/cascades are
dead). New GET /api/snapshot/summary (cache-only, before /:sport) +
Next proxy; HeartbeatBar shows the real graded count and SYNC =
elapsed since the last pipeline run (amber past 5 min).
0.3 Ticker: hardcoded fallback items deleted (real snapshot exhaust only);
MOVE kept — computeLineDeltas is real movement. <4 real items → no
ticker; bar publishes --ticker-h so the fixed header collapses cleanly.
0.4 /terminal retired: route redirects to /dashboard; VVI/injury-wire/
leaders layouts preserved unrouted as §12 content-engine templates.
Nav PRIMARY = Slate/Scan/Ledger; BottomTabBar Terminal→Explore; PWA
shortcut Terminal→Ledger; #terminal alias → /dashboard.
0.5 ›Query nav pill deleted (duplicate /scan link).
Backend 2289 → 2309 tests (199 suites), web build exit 0.
Spec: specs/phase-0-kill-the-lies.md. Next: work-order Phase 1 (ledger
persistence + settlement).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -25,7 +25,7 @@ describe('Phase C — routing config (lib/routes)', () => {
|
||||
});
|
||||
|
||||
it('leaves the landing + free funnel open (dashboard, scan stay public)', () => {
|
||||
['/', '/dashboard', '/scan', '/pricing', '/blog', '/terminal', '/login'].forEach((r) => {
|
||||
['/', '/dashboard', '/scan', '/pricing', '/blog', '/login'].forEach((r) => {
|
||||
expect(routes.isGatedRoute(r)).toBe(false);
|
||||
});
|
||||
});
|
||||
@@ -37,12 +37,17 @@ describe('Phase C — routing config (lib/routes)', () => {
|
||||
|
||||
it('resolves hash deep-link aliases to real routes', () => {
|
||||
expect(routes.resolveHashAlias('#scan')).toBe('/scan');
|
||||
expect(routes.resolveHashAlias('#terminal')).toBe('/terminal');
|
||||
// Session 57 (Phase 0) — /terminal retired; old links land on the slate.
|
||||
expect(routes.resolveHashAlias('#terminal')).toBe('/dashboard');
|
||||
expect(routes.resolveHashAlias('#slate')).toBe('/dashboard');
|
||||
expect(routes.resolveHashAlias('#nope')).toBeNull();
|
||||
expect(routes.resolveHashAlias('')).toBeNull();
|
||||
});
|
||||
|
||||
it('drops the retired /terminal surface from OPEN_ROUTES', () => {
|
||||
expect(routes.OPEN_ROUTES).not.toContain('/terminal');
|
||||
});
|
||||
|
||||
it('keeps GATED and OPEN route lists disjoint', () => {
|
||||
const overlap = routes.GATED_ROUTES.filter((r) => routes.OPEN_ROUTES.includes(r));
|
||||
expect(overlap).toEqual([]);
|
||||
@@ -77,11 +82,18 @@ describe('Phase C — Nav conversion', () => {
|
||||
expect(src).toContain("fontFamily: 'var(--mono)'");
|
||||
expect(src).toContain("'var(--g-a)'");
|
||||
});
|
||||
it('exposes the primary Slate/Terminal/Scan/Ledger routes', () => {
|
||||
['/dashboard', '/terminal', '/scan', '/ledger'].forEach((href) => {
|
||||
it('exposes the primary Slate/Scan/Ledger routes', () => {
|
||||
['/dashboard', '/scan', '/ledger'].forEach((href) => {
|
||||
expect(src).toContain(href);
|
||||
});
|
||||
});
|
||||
// Session 57 (Phase 0) — Terminal (fabricated surface) and the duplicate
|
||||
// ›Query pill are gone from the nav. Don't re-add either.
|
||||
it('does not link /terminal or render the ›Query duplicate', () => {
|
||||
expect(src).not.toContain("href: '/terminal'");
|
||||
expect(src).not.toContain('data-search-trigger');
|
||||
expect(src).not.toContain('>Query<');
|
||||
});
|
||||
});
|
||||
|
||||
describe('Phase C — Footer (system voice)', () => {
|
||||
|
||||
Reference in New Issue
Block a user