Session 59: Addendum + work-order 1.6 + Phase 2 + Phase 3 (2352 tests)
Overnight sprint for the Saturday 10 AM ET deploy gate — day one of the
public ledger record locks against freshly posted lines.
Task A — ledger team/opponent (migration 020, applied at 0 rows):
populated in both write paths from the real feed; opponent only when the
player's team matches a game participant (never guessed). Roadmap: Phase
4.5 WNBA ESPN-boxscore settlement (due ~Jul 24) + Phase 5 per-tier
calibration logged.
Task B — work-order 1.6 CLOSED (canonical player keys):
- searchPlayer resolves via nameKey; the old matcher deleted accents
("Sanchez" with acute -> "snchez") and substring-guessed onto the WRONG
player (the mismatched last-10 bug). Ambiguous -> null, never guess.
- Slate JOIN INVARIANT: a graded prop whose player's real team isn't in
the game is dropped (TB player can't render under MIL@PIT) — locked by
tests that fail the suite on regression.
- grades:{sport} TTL 2h -> 6h (expired between 5h cron gaps — the real
cause of /team "No active props" for slate players).
Task C — Phase 2 slate UX: tabs are THE filter (URL ?sport=, deep-linkable,
duplicate legacy tablist removed); cards cap at 6 graded props sorted
A+->F with ALL N READS in-place expander; waiting states show the real
next pipeline run ("Grades post ~6:00 PM ET").
Task D — Phase 3 mobile P0: root cause of vanished 390px nav was HIDE_ON
including '/' (landing had zero navigation) — fixed; html/body overflow-x
contained; GAME LINES collapses to best-line summary + "N BOOKS" expander
below 640px; venue drops before time/pitchers ever truncate.
Live verification: raw ESPN today STILL returns the Jun 13 NYK@SA Finals
game without a date pin; the pinned fetch returns 0 games, 0 off-date.
Backend 2327 -> 2352 tests (202 suites), web build exit 0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -747,6 +747,32 @@ phased plan in the Session-57 conversation / BUILD-STATE Next section).
|
||||
18000) via /api/snapshot/summary `expected_interval_s`. Phase 2.5 drops
|
||||
the value to the intraday cadence — no UI change needed.
|
||||
|
||||
## Player Keys + Slate Join + Mobile Nav (Session 59 — non-obvious)
|
||||
- **`mlbStatsAdapter.searchPlayer` resolves via `nameKey`** (canonical,
|
||||
accent-folded). NEVER reintroduce substring matching — it returned the
|
||||
WRONG player's id on a near-miss (the audit's mismatched last-10 bug).
|
||||
Fallback is unique last-name+first-initial or null: a missing profile
|
||||
beats another player's log.
|
||||
- **The slate JOIN INVARIANT** lives in `buildPlayerStripsFromProps(…,
|
||||
gameTeams)`: a graded prop whose player's real team (snapshot `team`,
|
||||
from the stats resolve) isn't a game participant is DROPPED. Props with
|
||||
no team info are kept (can't verify ≠ wrong). Tests in
|
||||
slateAdapterStrips lock it.
|
||||
- **grades:{sport} is written with SNAP_TTL (6h), NOT 2h** — the 2h TTL
|
||||
expired between 5h-apart cron runs and blanked /team + Explore mid-day.
|
||||
- **Sport tabs are THE filter** (?sport= URL param, history.replaceState).
|
||||
The dashboard has NO second tablist — legacy sections subscribe via
|
||||
Slate's `onTabChange`. Don't re-add a duplicate tab row.
|
||||
- **`lib/pipelineSchedule.js` mirrors SNAPSHOT_HOURS_UTC** (14,19,22,1,3)
|
||||
for "Grades post ~X ET" waiting states; a test cross-checks it against
|
||||
snapshotScheduler.HOURS_UTC. Change the cron → change both.
|
||||
- **BottomTabBar shows on '/'** — hiding it there left anon phones with
|
||||
ZERO navigation (desktop links hide <768, hamburger retired). HIDE_ON is
|
||||
auth flows only.
|
||||
- **GameCard collapse**: 6 graded props max (sorted A+→F), "ALL N READS →"
|
||||
expands in place; GAME LINES <640px = `.gl-summary` best-line row +
|
||||
expander revealing `.gl-full.gl-expanded`.
|
||||
|
||||
## Active Skills
|
||||
- vyndr-voice (all user-facing output)
|
||||
- prop-analysis (grading methodology)
|
||||
|
||||
Reference in New Issue
Block a user