Session 59: Addendum + work-order 1.6 + Phase 2 + Phase 3 (2352 tests)
Overnight sprint for the Saturday 10 AM ET deploy gate — day one of the
public ledger record locks against freshly posted lines.
Task A — ledger team/opponent (migration 020, applied at 0 rows):
populated in both write paths from the real feed; opponent only when the
player's team matches a game participant (never guessed). Roadmap: Phase
4.5 WNBA ESPN-boxscore settlement (due ~Jul 24) + Phase 5 per-tier
calibration logged.
Task B — work-order 1.6 CLOSED (canonical player keys):
- searchPlayer resolves via nameKey; the old matcher deleted accents
("Sanchez" with acute -> "snchez") and substring-guessed onto the WRONG
player (the mismatched last-10 bug). Ambiguous -> null, never guess.
- Slate JOIN INVARIANT: a graded prop whose player's real team isn't in
the game is dropped (TB player can't render under MIL@PIT) — locked by
tests that fail the suite on regression.
- grades:{sport} TTL 2h -> 6h (expired between 5h cron gaps — the real
cause of /team "No active props" for slate players).
Task C — Phase 2 slate UX: tabs are THE filter (URL ?sport=, deep-linkable,
duplicate legacy tablist removed); cards cap at 6 graded props sorted
A+->F with ALL N READS in-place expander; waiting states show the real
next pipeline run ("Grades post ~6:00 PM ET").
Task D — Phase 3 mobile P0: root cause of vanished 390px nav was HIDE_ON
including '/' (landing had zero navigation) — fixed; html/body overflow-x
contained; GAME LINES collapses to best-line summary + "N BOOKS" expander
below 640px; venue drops before time/pitchers ever truncate.
Live verification: raw ESPN today STILL returns the Jun 13 NYK@SA Finals
game without a date pin; the pinned fetch returns 0 games, 0 off-date.
Backend 2327 -> 2352 tests (202 suites), web build exit 0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -73,6 +73,33 @@ const sideOf = (direction) =>
|
||||
// fabricated zero line/odds is exactly what the data-semantics rule forbids).
|
||||
const numOrNull = (v) => (v == null || !Number.isFinite(Number(v)) ? null : Number(v));
|
||||
|
||||
// Nickname token (last word, lowercased) — the stable cross-source team
|
||||
// identifier ("New York Yankees" ↔ "Yankees" ↔ "NYY" won't match, but
|
||||
// full-name feeds match full-name feeds; abbr feeds match abbr feeds).
|
||||
const nickToken = (name) => {
|
||||
const w = String(name || '').trim().split(/\s+/);
|
||||
return (w[w.length - 1] || '').toLowerCase().replace(/[^a-z]/g, '');
|
||||
};
|
||||
const teamsMatch = (a, b) => {
|
||||
if (!a || !b) return false;
|
||||
const sa = String(a).toLowerCase(), sb = String(b).toLowerCase();
|
||||
return sa === sb || nickToken(a) === nickToken(b);
|
||||
};
|
||||
|
||||
/**
|
||||
* Session 59 — team/opponent from the REAL feed. The player's team comes
|
||||
* from the stats resolve (g.team); the opponent is the other side of the
|
||||
* prop's game IF the team matches one of its participants. No match →
|
||||
* opponent stays null — never guessed.
|
||||
*/
|
||||
function teamOpponentFor(g, prop) {
|
||||
const team = g && g.team ? String(g.team) : null;
|
||||
if (!team || !prop) return { team, opponent: null };
|
||||
if (teamsMatch(team, prop.home_team)) return { team, opponent: prop.away_team || null };
|
||||
if (teamsMatch(team, prop.away_team)) return { team, opponent: prop.home_team || null };
|
||||
return { team, opponent: null };
|
||||
}
|
||||
|
||||
/** Index odds props by nameKey|stat for lock/closing lookups. */
|
||||
function indexProps(props) {
|
||||
const map = {};
|
||||
@@ -114,7 +141,10 @@ function rowsFromSnapshot(sport, grades, oddsProps, nowIso) {
|
||||
const prop = byKey[`${nameKey(player)}|${stat}`] || null;
|
||||
const gradedTs = locked.timestamp || nowIso;
|
||||
const gameDate = dateET(prop && prop.game_time) || dateET(gradedTs) || todayET();
|
||||
const { team, opponent } = teamOpponentFor(g, prop);
|
||||
rows.push({
|
||||
team,
|
||||
opponent,
|
||||
user_id: null,
|
||||
player_key: nameKey(player),
|
||||
player_name: normalizeName(player).display || player,
|
||||
@@ -375,5 +405,6 @@ module.exports = {
|
||||
__internals: {
|
||||
rowsFromSnapshot, computeClv, clvResultOf, indexProps, gameIdFor,
|
||||
dateET, sideOf, oddsForSide, isConfigured, CONFLICT,
|
||||
teamOpponentFor, teamsMatch,
|
||||
},
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user