Session 59: Addendum + work-order 1.6 + Phase 2 + Phase 3 (2352 tests)
Overnight sprint for the Saturday 10 AM ET deploy gate — day one of the
public ledger record locks against freshly posted lines.
Task A — ledger team/opponent (migration 020, applied at 0 rows):
populated in both write paths from the real feed; opponent only when the
player's team matches a game participant (never guessed). Roadmap: Phase
4.5 WNBA ESPN-boxscore settlement (due ~Jul 24) + Phase 5 per-tier
calibration logged.
Task B — work-order 1.6 CLOSED (canonical player keys):
- searchPlayer resolves via nameKey; the old matcher deleted accents
("Sanchez" with acute -> "snchez") and substring-guessed onto the WRONG
player (the mismatched last-10 bug). Ambiguous -> null, never guess.
- Slate JOIN INVARIANT: a graded prop whose player's real team isn't in
the game is dropped (TB player can't render under MIL@PIT) — locked by
tests that fail the suite on regression.
- grades:{sport} TTL 2h -> 6h (expired between 5h cron gaps — the real
cause of /team "No active props" for slate players).
Task C — Phase 2 slate UX: tabs are THE filter (URL ?sport=, deep-linkable,
duplicate legacy tablist removed); cards cap at 6 graded props sorted
A+->F with ALL N READS in-place expander; waiting states show the real
next pipeline run ("Grades post ~6:00 PM ET").
Task D — Phase 3 mobile P0: root cause of vanished 390px nav was HIDE_ON
including '/' (landing had zero navigation) — fixed; html/body overflow-x
contained; GAME LINES collapses to best-line summary + "N BOOKS" expander
below 640px; venue drops before time/pitchers ever truncate.
Live verification: raw ESPN today STILL returns the Jun 13 NYK@SA Finals
game without a date pin; the pinned fetch returns 0 games, 0 off-date.
Backend 2327 -> 2352 tests (202 suites), web build exit 0.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -110,3 +110,66 @@ describe('Phase F — PWA manifest + viewport (§11)', () => {
|
||||
expect(read('app/layout.tsx')).toContain("viewportFit: 'cover'");
|
||||
});
|
||||
});
|
||||
|
||||
// ── Session 59 — work-order Phase 3 (mobile P0) + Phase 2 slate UX ──────────
|
||||
|
||||
describe('Phase 3.1 — the tab bar is the mobile nav EVERYWHERE except auth', () => {
|
||||
const src = read('components/BottomTabBar.tsx');
|
||||
it('does NOT hide on the landing (anon phones had zero navigation)', () => {
|
||||
const hideOn = src.match(/const HIDE_ON = new Set\(\[([^\]]*)\]\)/);
|
||||
expect(hideOn).toBeTruthy();
|
||||
expect(hideOn[1]).not.toContain("'/'");
|
||||
['/login', '/signup', '/auth/callback'].forEach((p) => expect(hideOn[1]).toContain(p));
|
||||
});
|
||||
});
|
||||
|
||||
describe('Phase 3.2 — overflow containment at 390px', () => {
|
||||
const css = read('app/globals.css');
|
||||
it('document never scrolls horizontally on phones', () => {
|
||||
expect(css).toMatch(/@media \(max-width: 767px\)[\s\S]*?html, body \{ overflow-x: hidden/);
|
||||
});
|
||||
it('venue drops first on phones (time/pitchers never truncate)', () => {
|
||||
expect(css).toContain('.gc-venue { display: none');
|
||||
expect(read('components/vyndr/GameCard.tsx')).toContain('className="gc-venue"');
|
||||
});
|
||||
it('book table collapses to a best-line summary with an expander below md', () => {
|
||||
expect(css).toContain('.gl-summary { display: none; }');
|
||||
expect(css).toContain('.gl-full:not(.gl-expanded) { display: none');
|
||||
const card = read('components/vyndr/GameCard.tsx');
|
||||
expect(card).toContain('gl-summary');
|
||||
expect(card).toContain('BOOKS {linesExpanded');
|
||||
});
|
||||
});
|
||||
|
||||
describe('Phase 2.2 — card collapse (6-prop cap, ALL N READS)', () => {
|
||||
const card = read('components/vyndr/GameCard.tsx');
|
||||
it('caps visible graded props and sorts strips best-grade-first', () => {
|
||||
expect(card).toContain('MAX_VISIBLE_PROPS = 6');
|
||||
expect(card).toMatch(/sort\(\(a, b\) => stripBestRank\(a\) - stripBestRank\(b\)\)/);
|
||||
});
|
||||
it('offers the ALL N READS expander in place', () => {
|
||||
expect(card).toContain('ALL {collapsed.totalReads} READS →');
|
||||
expect(card).toContain('COLLAPSE ↑');
|
||||
});
|
||||
});
|
||||
|
||||
describe('Phase 2.1 — sport tabs are THE filter, URL-driven', () => {
|
||||
const slate = read('components/Slate.tsx');
|
||||
it('reads and writes ?sport= on the URL', () => {
|
||||
expect(slate).toContain(".get('sport')"); // tabFromUrl reads the deep link
|
||||
expect(slate).toContain("url.searchParams.set('sport', t)");
|
||||
expect(slate).toContain('history.replaceState');
|
||||
});
|
||||
it('the dashboard has NO second tablist — it subscribes via onTabChange', () => {
|
||||
const dash = read('app/dashboard/page.tsx');
|
||||
expect(dash).toContain('onTabChange');
|
||||
expect(dash).not.toMatch(/role="tablist"\s+aria-label="Sport"/);
|
||||
});
|
||||
});
|
||||
|
||||
describe('Phase 2.3 — honest waiting states', () => {
|
||||
it('awaiting props show the real next pipeline run, not passive mystery', () => {
|
||||
expect(read('components/vyndr/StatStrip.tsx')).toContain('nextRunLabelET');
|
||||
expect(read('app/dashboard/page.tsx')).toContain('nextRunLabelET');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user