Merge S7 (a1): newsletter — THE VYNDR REPORT

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

# Conflicts:
#	BUILD-STATE.md
#	CLAUDE.md
This commit is contained in:
Kev
2026-07-11 14:32:18 -04:00
14 changed files with 1297 additions and 0 deletions
+28
View File
@@ -826,6 +826,34 @@ phased plan in the Session-57 conversation / BUILD-STATE Next section).
- **Worktree build gotcha:** `web/node_modules` isn't shared into git worktrees
and Turbopack REJECTS a symlink pointing outside the project root — use
`cp -al` (hardlink copy) from the main repo's web/node_modules.
## Newsletter — THE VYNDR REPORT (Session S7, a1 — non-obvious)
- **`newsletterService`** is the whole layer: `buildDailyReport(sports, deps)`
(deterministic VOICE v1.1 template over snapshot grades + streak lens +
`getModelAggregate`; every dep injectable), `subscribe(email)` and
`sendDailyReport(opts)` (Listmonk, self-hosted, zero out-of-pocket). ALL
Listmonk paths are env-gated on `LISTMONK_URL/USER/TOKEN/LIST_ID` — any
missing → `{ ok:false, reason:'not configured' }`, and the capture UI shows
"Signups open soon". Auth is the API-user scheme `Authorization: token
user:token`, NOT basic auth.
- **Double opt-in is Listmonk's job:** subscribe sends
`preconfirm_subscriptions:false`; the list itself must be created as
double-opt-in (runbook: `docs/NEWSLETTER.md`). The email template embeds the
LITERAL `{{ UnsubscribeURL }}` — Listmonk substitutes per-recipient; never
"fix" it. A 409 (already subscribed) is returned as ok — no enumeration.
- **The send is deliberately unscheduled.** Only `POST
/api/internal/newsletter/send` (internal key) triggers it; an empty report
(0 signals AND 0 streaks) refuses to send. The record line renders a
percentage ONLY when `hit_pct != null` (n≥20 gate upstream in
`getModelAggregate`), else "RECORD BUILDING · N pending".
- **VOICE lint is executable:** `tests/unit/newsletterService.test.js` fails on
any `!`, banned vocabulary (word-boundary regex), or hype emoji in
subject/html/text. The RG disclaimer says "No outcome is promised" — the word
"guarantee" trips the lint even in a disclaimer, keep it out.
- **Capture placement:** the signup "done" card auto-redirects after 1.5s
(`setTimeout(router.replace)`) — useless for a form. The free-signup success
surface is `/welcome`. Landing capture sits below FAQ. Subscribe route is
10/min IP-limited → keep `tests/integration/newsletterRoute.test.js` under 10
subscribe requests (same lesson as analyze.test.js).
## Active Skills
- vyndr-voice (all user-facing output)