builtbykev
3f7aa368c4
LIVE was switched on in production and nothing happened, because
`snapshotGating.stripModelPrice` contained
try { rows = require(...).applyToRows(rows); } catch { }
`rows` is not declared in that function — the parameter is `grades`. Under
'use strict' that is a ReferenceError on every call, and the empty catch
swallowed it. For an entire release the seam was dead, the status surface
reported LIVE ON, and every row was served raw.
Two failures, and the second is the one that mattered: a silent catch turned a
hard crash into nothing at all. It now names the failure in the log and degrades
to uncalibrated rows explicitly.
The entitled branch also returned `grades` — the original array — so even a
working seam would have had its output discarded for exactly the tier meant to
receive it. Both fixed; `grades` is threaded through.
MY TESTS COULD NOT SEE IT. They called `applyToRows` directly and grepped the
source for the require line. Neither exercises the boundary, and a source grep
is not proof a line runs: the dead wiring contained that exact require. The new
tests call `stripModelPrice` and assert on its RETURN VALUE, entitled and
unentitled, plus a throwing-seam case that requires the warning.
Verified on real production rows through the real entitled path:
0.706 -> 0.625 CERTIFIED, EV recomputed 8.7 -> -3.7, grade B unchanged
0.858 -> unavailable UNCERTIFIED, its value:true WITHDRAWN, grade B+ unchanged
rbi -> untouched
free tier -> model fields still stripped
Found only because the live acceptance measured real rows instead of trusting a
green suite.
Suite 407/407, 5,697 passed. Teeth 48/48 + 10/10 + 23/23.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CQJeAG8vcDoL5zkiaJyVb8