7b85934dc3
The platoon test's n=452 described how much of the JOIN survived, not how much data exists. There are 1,266 clean settled hits rows and zero quarantined ones. platoon_splits had been ingested from tonight's lineups only (315 players), so any hitter who settled a prop without appearing in an ingest-day lineup was silently absent from every test. Backfilled all 380 hitters (81 fetched, 0 unresolved). Re-ran on 1,059 rows, up from 452. THE DEMOTION IS THE HEADLINE. pitcher_contact_profile, the strongest proven factor in the programme (-0.0064, CI [-0.0113,-0.0014]), roughly halved to -0.0034 on more than double the sample and its corrected interval now spans zero. The Bonferroni denominator also rose to 55, which widens every interval -- but a denominator cannot move a point estimate, and that halved on its own. platoon and platoon_severity now clear the bar and are NOT promoted. Upper bound -0.0001, on season-to-date splits that contain the games they predict: measured contamination is 4.5% median, 12.4% at p90, 137% worst. I had assumed ~1%. They stay CANDIDATE pending point-in-time splits. GAME-LEVEL IS A DIFFERENT PROBLEM. game_context held zero weather rows ever -- not because the fetcher was wrong (it correctly targets Open-Meteo's archive) but because ledger_entries keys a game as mlb:2026-08-03:Away@Home and game_context keys it as mlb:823437. Every lookup missed and NULL columns read as honest absence. Third occurrence of that class. Fixed the join: 96/101 settled games now carry actual archived weather, park dimensions backfilled 15 -> 30 venues. But 928 total_bases rows sit on 47 games at 17.6 rows per game. Park and weather assign one value per game, so resampling rows would have manufactured a pass. factorGate now resamples clusters when rows carry one and judges sample against effective_n; unclustered rows keep the original path byte-for-byte. Verdict: 47 clusters < 500, and the point estimate is +0.0011 -- worse, not merely unproven. Weather needs ~57 more days. Park dimensions need never: there are 30 ballparks in MLB, so a venue-constant factor can never reach 500 independent units. That bar was built for player-level factors and does not transfer. Wind is refused. We have speed and bearing for all 96 games; we lack park orientation, and 220 degrees is blowing out at one park and in at another. Using speed alone would assert an effect while discarding the sign that decides what it is. Counter and frozen clusters untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W1sivYNqY2TS5ftykmHBU9
171 lines
6.8 KiB
JavaScript
171 lines
6.8 KiB
JavaScript
#!/usr/bin/env node
|
|
'use strict';
|
|
|
|
/**
|
|
* reconstruct-game-environment — GIVE THE PAST GAMES THEIR REAL CONDITIONS.
|
|
*
|
|
* `game_context` has never held a single weather reading. The reason is not the
|
|
* fetcher, which is correct and points at Open-Meteo's ARCHIVE endpoint; it is
|
|
* that nothing ever joined. The ledger keys a game as
|
|
* `mlb:2026-08-03:WashingtonNationals@PhiladelphiaPhillies` and game_context
|
|
* keys it as `mlb:823437`, so every lookup missed and the columns stayed NULL —
|
|
* which reads exactly like "the weather was unavailable" rather than "the two
|
|
* tables have never been introduced." The same class of failure as the doubled
|
|
* /leaderboard path: graceful degradation wearing the mask of honest absence.
|
|
*
|
|
* This walks the dates in the settled ledger, resolves each slug to the real
|
|
* statsapi game and venue, and writes a game_context row keyed by the LEDGER's
|
|
* slug so the join exists. Then it pulls the actual archived weather for that
|
|
* date and location.
|
|
*
|
|
* ARCHIVE, NOT FORECAST — asking the forecast endpoint about a past date returns
|
|
* a re-forecast, which is a model's opinion about the past, not the past. Absent
|
|
* stays NULL; nothing here is imputed.
|
|
*
|
|
* SUPABASE_URL=... node scripts/reconstruct-game-environment.js
|
|
*/
|
|
|
|
require('dotenv').config();
|
|
const axios = require('axios');
|
|
const { createClient } = require('@supabase/supabase-js');
|
|
|
|
const SB_URL = process.env.SUPABASE_URL;
|
|
const SB_KEY = process.env.SUPABASE_SERVICE_ROLE_KEY || process.env.SUPABASE_SERVICE_KEY;
|
|
const PAGE = 1000;
|
|
const SCHEDULE = (d) => `https://statsapi.mlb.com/api/v1/schedule?sportId=1&date=${d}&hydrate=venue(location)`;
|
|
const ARCHIVE = (lat, lon, date) =>
|
|
`https://archive-api.open-meteo.com/v1/archive?latitude=${lat}&longitude=${lon}`
|
|
+ `&start_date=${date}&end_date=${date}`
|
|
+ '&hourly=temperature_2m,wind_speed_10m,wind_direction_10m,precipitation'
|
|
+ '&temperature_unit=fahrenheit&wind_speed_unit=mph';
|
|
|
|
const squash = (s) => String(s || '').toLowerCase().replace(/[^a-z]/g, '');
|
|
|
|
async function page(sb, table, select, apply) {
|
|
const out = [];
|
|
for (let from = 0; ; from += PAGE) {
|
|
const { data, error } = await apply(sb.from(table).select(select)).range(from, from + PAGE - 1);
|
|
if (error) throw error;
|
|
if (!data || data.length === 0) break;
|
|
out.push(...data);
|
|
if (data.length < PAGE) break;
|
|
}
|
|
return out;
|
|
}
|
|
|
|
const get = async (url) => (await axios.get(url, { timeout: 60_000 })).data;
|
|
|
|
async function main() {
|
|
const sb = createClient(SB_URL, SB_KEY, { auth: { persistSession: false } });
|
|
|
|
const led = await page(sb, 'ledger_entries', 'game_id, game_date, stat, outcome, quarantine_reason',
|
|
(q) => q.eq('sport', 'mlb').is('user_id', null).in('stat', ['hits', 'total_bases'])
|
|
.in('outcome', ['hit', 'miss']));
|
|
const clean = led.filter((r) => !(r.quarantine_reason || '').startsWith('nontakeable_book'));
|
|
|
|
// Distinct games, as the LEDGER names them.
|
|
const games = new Map();
|
|
for (const r of clean) if (r.game_id && !games.has(r.game_id)) games.set(r.game_id, r.game_date);
|
|
const dates = [...new Set([...games.values()])].sort();
|
|
console.error(`[env] ${games.size} distinct settled games across ${dates.length} dates`);
|
|
|
|
// date -> statsapi games, indexed by the same squashed away@home the slug uses.
|
|
const resolved = new Map();
|
|
const venues = new Map();
|
|
for (const d of dates) {
|
|
let sched = null;
|
|
try { sched = await get(SCHEDULE(d)); } catch { sched = null; }
|
|
for (const day of (sched && sched.dates) || []) {
|
|
for (const g of day.games || []) {
|
|
const away = squash(g.teams?.away?.team?.name);
|
|
const home = squash(g.teams?.home?.team?.name);
|
|
resolved.set(`${d}|${away}@${home}`, g);
|
|
const v = g.venue || {};
|
|
if (v.id && !venues.has(v.id)) {
|
|
const loc = v.location || {};
|
|
venues.set(v.id, {
|
|
venue_id: v.id,
|
|
venue_name: v.name || null,
|
|
lat: loc.defaultCoordinates?.latitude ?? null,
|
|
lon: loc.defaultCoordinates?.longitude ?? null,
|
|
});
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Join each ledger slug to its real game + venue.
|
|
const rows = []; let unmatched = 0;
|
|
for (const [gid, date] of games) {
|
|
const m = /^mlb:(\d{4}-\d{2}-\d{2}):(.+?)@(.+)$/.exec(gid);
|
|
if (!m) { unmatched += 1; continue; }
|
|
const g = resolved.get(`${m[1]}|${squash(m[2])}@${squash(m[3])}`);
|
|
if (!g) { unmatched += 1; continue; }
|
|
rows.push({
|
|
game_id: gid, // the LEDGER's key — this is the whole fix
|
|
game_date: date,
|
|
venue_id: g.venue?.id ?? null,
|
|
source_game_pk: g.gamePk ?? null,
|
|
});
|
|
}
|
|
console.error(`[env] matched ${rows.length}, unmatched ${unmatched}, venues seen ${venues.size}`);
|
|
|
|
for (let i = 0; i < rows.length; i += 200) {
|
|
const { error } = await sb.from('game_context')
|
|
.upsert(rows.slice(i, i + 200), { onConflict: 'game_id' });
|
|
if (error) console.error('[env] context write failed:', error.message);
|
|
}
|
|
|
|
// ACTUAL archived weather, one call per (venue, date) that we need.
|
|
const need = new Map();
|
|
for (const r of rows) {
|
|
const v = venues.get(r.venue_id);
|
|
if (!v || v.lat == null || v.lon == null) continue;
|
|
need.set(`${r.venue_id}|${r.game_date}`, { v, date: r.game_date });
|
|
}
|
|
console.error(`[env] fetching ${need.size} venue-days of archived weather`);
|
|
|
|
const wx = new Map();
|
|
for (const [k, { v, date }] of need) {
|
|
try {
|
|
const p = await get(ARCHIVE(v.lat, v.lon, date));
|
|
const h = p && p.hourly;
|
|
if (h && Array.isArray(h.time) && h.time.length) {
|
|
const i = Math.min(h.time.length - 1, 19); // ~7pm local, typical first pitch
|
|
wx.set(k, {
|
|
wx_temp_f: h.temperature_2m?.[i] ?? null,
|
|
wx_wind_speed_mph: h.wind_speed_10m?.[i] ?? null,
|
|
wx_wind_direction_deg: h.wind_direction_10m?.[i] ?? null,
|
|
wx_precip_mm: h.precipitation?.[i] ?? null,
|
|
wx_source: 'open_meteo_archive',
|
|
});
|
|
}
|
|
} catch { /* absent stays absent */ }
|
|
}
|
|
|
|
let withWx = 0;
|
|
for (let i = 0; i < rows.length; i += 200) {
|
|
const batch = rows.slice(i, i + 200).map((r) => {
|
|
const w = wx.get(`${r.venue_id}|${r.game_date}`);
|
|
if (w) withWx += 1;
|
|
return w ? { ...r, ...w } : r;
|
|
});
|
|
const { error } = await sb.from('game_context').upsert(batch, { onConflict: 'game_id' });
|
|
if (error) console.error('[env] weather write failed:', error.message);
|
|
}
|
|
|
|
console.log(JSON.stringify({
|
|
settled_games: games.size,
|
|
matched_to_statsapi: rows.length,
|
|
unmatched,
|
|
distinct_venues: venues.size,
|
|
venue_days_requested: need.size,
|
|
venue_days_returned: wx.size,
|
|
game_rows_with_actual_weather: withWx,
|
|
source: 'open_meteo_archive (actual, not re-forecast)',
|
|
}, null, 2));
|
|
process.exit(0);
|
|
}
|
|
|
|
main().catch((e) => { console.error(e); process.exit(1); });
|