c8790fde55
Work-order Phase 0 (Jul 10 live audit): every fabricated UI element deleted
or rewired to real data. Deletion sprint — no new product features.
0.1 Fake NBA game: root cause was scheduleService fetching the ESPN
scoreboard with no ?dates= param or date filter — off-season ESPN
returns the NEAREST slate (Jun 13 NYK@SA Finals rendered as tonight).
Now pinned to the requested ET date + defensive filter; undated events
dropped. Honest month-aware per-sport empty states (lib/emptyState.js).
0.2 Fake header counters: liveTick stripped to a bare 1s pulse (the
auto-incrementing "247 graded", sin-driven brain-%, aPlus/cascades are
dead). New GET /api/snapshot/summary (cache-only, before /:sport) +
Next proxy; HeartbeatBar shows the real graded count and SYNC =
elapsed since the last pipeline run (amber past 5 min).
0.3 Ticker: hardcoded fallback items deleted (real snapshot exhaust only);
MOVE kept — computeLineDeltas is real movement. <4 real items → no
ticker; bar publishes --ticker-h so the fixed header collapses cleanly.
0.4 /terminal retired: route redirects to /dashboard; VVI/injury-wire/
leaders layouts preserved unrouted as §12 content-engine templates.
Nav PRIMARY = Slate/Scan/Ledger; BottomTabBar Terminal→Explore; PWA
shortcut Terminal→Ledger; #terminal alias → /dashboard.
0.5 ›Query nav pill deleted (duplicate /scan link).
Backend 2289 → 2309 tests (199 suites), web build exit 0.
Spec: specs/phase-0-kill-the-lies.md. Next: work-order Phase 1 (ledger
persistence + settlement).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
183 lines
7.0 KiB
JavaScript
183 lines
7.0 KiB
JavaScript
// Integration: /api/schedule/:sport (Session 23).
|
|
//
|
|
// The schedule service is mocked at the redis layer so we exercise the
|
|
// route + service normalization + flag enrichment without hitting ESPN
|
|
// or a live Redis. ESPN itself is stubbed via axios.
|
|
|
|
const express = require('express');
|
|
const request = require('supertest');
|
|
|
|
jest.mock('axios');
|
|
const axios = require('axios');
|
|
|
|
// In-memory redis stand-in. cacheGet returns whatever we seed; cacheSet
|
|
// records writes so we can assert the cache-aside warm path.
|
|
const store = {};
|
|
jest.mock('../../src/utils/redis', () => ({
|
|
cacheGet: jest.fn(async (k) => (k in store ? store[k] : null)),
|
|
cacheSet: jest.fn(async (k, v) => { store[k] = v; return true; }),
|
|
}));
|
|
|
|
function mountApp() {
|
|
delete require.cache[require.resolve('../../src/routes/schedule')];
|
|
delete require.cache[require.resolve('../../src/services/scheduleService')];
|
|
const scheduleRoutes = require('../../src/routes/schedule');
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use('/api/schedule', scheduleRoutes);
|
|
return app;
|
|
}
|
|
|
|
// NOTE (Session 57, Phase 0): the event date must fall on the REQUESTED ET
|
|
// date (2026-06-12) — 00:40Z Jun 13 = 20:40 ET Jun 12. The old fixture was
|
|
// dated a day later and the route served it anyway; that exact hole is how the
|
|
// Jun 13 NYK@SA Finals game kept rendering as "tonight" all July.
|
|
const ESPN_NBA = {
|
|
data: {
|
|
events: [
|
|
{
|
|
id: '401234567',
|
|
date: '2026-06-13T00:40:00Z',
|
|
status: { type: { state: 'pre' } },
|
|
competitions: [{
|
|
venue: { fullName: 'Frost Bank Center' },
|
|
broadcasts: [{ names: ['ABC'] }],
|
|
competitors: [
|
|
{ homeAway: 'home', score: '0', team: { displayName: 'San Antonio Spurs', abbreviation: 'SA' } },
|
|
{ homeAway: 'away', score: '0', team: { displayName: 'New York Knicks', abbreviation: 'NYK' } },
|
|
],
|
|
}],
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
beforeEach(() => {
|
|
for (const k of Object.keys(store)) delete store[k];
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
describe('GET /api/schedule/:sport', () => {
|
|
test('returns normalized games from a fresh ESPN fetch (cache miss)', async () => {
|
|
axios.get.mockResolvedValue(ESPN_NBA);
|
|
const res = await request(mountApp()).get('/api/schedule/nba?date=2026-06-12');
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.sport).toBe('nba');
|
|
expect(res.body.source).toBe('espn');
|
|
expect(res.body.games).toHaveLength(1);
|
|
const g = res.body.games[0];
|
|
expect(g.homeTeam.abbreviation).toBe('SA');
|
|
expect(g.awayTeam.name).toBe('New York Knicks');
|
|
expect(g.status).toBe('pre');
|
|
expect(g.venue).toBe('Frost Bank Center');
|
|
expect(g.broadcast).toBe('ABC');
|
|
expect(g.score).toBeNull(); // pre-game → no score
|
|
expect(g.hasOdds).toBe(false);
|
|
expect(g.hasGameLines).toBe(false);
|
|
});
|
|
|
|
test('warms the cache, second call does not re-fetch ESPN', async () => {
|
|
axios.get.mockResolvedValue(ESPN_NBA);
|
|
const app = mountApp();
|
|
await request(app).get('/api/schedule/nba?date=2026-06-12');
|
|
const callsAfterFirst = axios.get.mock.calls.length;
|
|
await request(app).get('/api/schedule/nba?date=2026-06-12');
|
|
expect(axios.get.mock.calls.length).toBe(callsAfterFirst); // served from cache
|
|
});
|
|
|
|
test('pins the ESPN fetch to the requested date (?dates=YYYYMMDD)', async () => {
|
|
axios.get.mockResolvedValue(ESPN_NBA);
|
|
await request(mountApp()).get('/api/schedule/nba?date=2026-06-12');
|
|
expect(axios.get.mock.calls[0][0]).toContain('dates=20260612');
|
|
});
|
|
|
|
// Session 57 (Phase 0) regression — in the off-season ESPN returns the
|
|
// NEAREST slate, not today's. Any event whose ET date ≠ the requested date
|
|
// must be dropped, or a June Finals game renders as tonight's slate in July.
|
|
test('filters out events from a different ET date (fake off-season game)', async () => {
|
|
axios.get.mockResolvedValue({
|
|
data: {
|
|
events: [
|
|
{
|
|
id: '401999999',
|
|
date: '2026-06-14T00:30:00Z', // Jun 13 ET — NOT the requested Jun 12
|
|
status: { type: { state: 'pre' } },
|
|
competitions: [{
|
|
competitors: [
|
|
{ homeAway: 'home', score: '0', team: { displayName: 'San Antonio Spurs', abbreviation: 'SA' } },
|
|
{ homeAway: 'away', score: '0', team: { displayName: 'New York Knicks', abbreviation: 'NYK' } },
|
|
],
|
|
}],
|
|
},
|
|
],
|
|
},
|
|
});
|
|
const res = await request(mountApp()).get('/api/schedule/nba?date=2026-06-12');
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.games).toEqual([]);
|
|
});
|
|
|
|
test('drops events with no parseable date (live feed only)', async () => {
|
|
axios.get.mockResolvedValue({
|
|
data: {
|
|
events: [{
|
|
id: '77', // no `date` field at all
|
|
status: { type: { state: 'pre' } },
|
|
competitions: [{
|
|
competitors: [
|
|
{ homeAway: 'home', score: '0', team: { displayName: 'A', abbreviation: 'A' } },
|
|
{ homeAway: 'away', score: '0', team: { displayName: 'B', abbreviation: 'B' } },
|
|
],
|
|
}],
|
|
}],
|
|
},
|
|
});
|
|
const res = await request(mountApp()).get('/api/schedule/nba?date=2026-06-12');
|
|
expect(res.body.games).toEqual([]);
|
|
});
|
|
|
|
test('returns empty array (not error) when no games today', async () => {
|
|
axios.get.mockResolvedValue({ data: { events: [] } });
|
|
const res = await request(mountApp()).get('/api/schedule/mlb?date=2026-06-12');
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.games).toEqual([]);
|
|
});
|
|
|
|
test('hasOdds true when odds-api cache has props for the slate', async () => {
|
|
store['odds:nba:2026-06-12'] = { updated_at: 'x', props: [{ player: 'Wemby' }] };
|
|
axios.get.mockResolvedValue(ESPN_NBA);
|
|
const res = await request(mountApp()).get('/api/schedule/nba?date=2026-06-12');
|
|
expect(res.body.games[0].hasOdds).toBe(true);
|
|
expect(res.body.games[0].hasGameLines).toBe(false);
|
|
});
|
|
|
|
test('hasGameLines true when Tank01 odds cache has data', async () => {
|
|
store['tank01:nba:odds:20260612'] = { body: { '20260612_NYK@SA': { homeML: '-110' } } };
|
|
axios.get.mockResolvedValue(ESPN_NBA);
|
|
const res = await request(mountApp()).get('/api/schedule/nba?date=2026-06-12');
|
|
expect(res.body.games[0].hasGameLines).toBe(true);
|
|
});
|
|
|
|
test('scores appear once a game is in/post', async () => {
|
|
axios.get.mockResolvedValue({
|
|
data: { events: [{
|
|
id: '9', date: '2026-06-12T20:00:00Z',
|
|
status: { type: { state: 'in' } },
|
|
competitions: [{
|
|
competitors: [
|
|
{ homeAway: 'home', score: '54', team: { displayName: 'A', abbreviation: 'A' } },
|
|
{ homeAway: 'away', score: '49', team: { displayName: 'B', abbreviation: 'B' } },
|
|
],
|
|
}],
|
|
}] },
|
|
});
|
|
const res = await request(mountApp()).get('/api/schedule/nba?date=2026-06-12');
|
|
expect(res.body.games[0].score).toEqual({ home: 54, away: 49 });
|
|
});
|
|
|
|
test('unknown sport returns 404', async () => {
|
|
const res = await request(mountApp()).get('/api/schedule/cricket');
|
|
expect(res.status).toBe(404);
|
|
});
|
|
});
|